-
-
Notifications
You must be signed in to change notification settings - Fork 226
Ensure template is not sent for Structured logs with no parameters #4544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
+ Coverage 73.33% 73.48% +0.14%
==========================================
Files 479 482 +3
Lines 17509 17679 +170
Branches 3445 3495 +50
==========================================
+ Hits 12840 12991 +151
- Misses 3789 3798 +9
- Partials 880 890 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Flash0ver
reviewed
Sep 22, 2025
Flash0ver
reviewed
Sep 25, 2025
Flash0ver
reviewed
Sep 25, 2025
Flash0ver
reviewed
Sep 25, 2025
Co-authored-by: Stefan Pölz <[email protected]>
Co-authored-by: Stefan Pölz <[email protected]>
Flash0ver
approved these changes
Oct 1, 2025
This was referenced Oct 2, 2025
This was referenced Oct 2, 2025
alexsohn1126
pushed a commit
that referenced
this pull request
Oct 11, 2025
…4544) Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: Stefan Pölz <[email protected]>
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4480:
sentry.message.template
on logs ifsentry.message.parameter
values are also defined #4480Note
Skip emitting
sentry.message.template
in structured logs without parameters; adds coverage and updates changelog.src/Sentry/SentryLog.cs
to only writeattributes.sentry.message.template
whenTemplate
is set andParameters
has length > 0.WriteTo_NoParameters_NoTemplate
theory intest/Sentry.Tests/SentryLogTests.cs
to assert presence/absence ofsentry.message.template
based on parameters.CHANGELOG.md
under Fixes to note templates aren’t sent for logs without parameters.Written by Cursor Bugbot for commit faad68a. This will update automatically on new commits. Configure here.